Skip to content

fix(structure-comparison): syntax error when executing structure comparison#2638

Merged
yhilmare merged 6 commits into
dev/4.3.0from
fix/shanlu_fix_parti_ddl
Jun 5, 2024
Merged

fix(structure-comparison): syntax error when executing structure comparison#2638
yhilmare merged 6 commits into
dev/4.3.0from
fix/shanlu_fix_parti_ddl

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare commented Jun 4, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

the table editor append partition 5 into the partition defs which is wrong, this pr fix this problem~

Which issue(s) this PR fixes:

Fixes #2491

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Jun 4, 2024
@yhilmare yhilmare added this to the ODC 4.3.0 milestone Jun 4, 2024
@yhilmare yhilmare self-assigned this Jun 4, 2024
@yhilmare yhilmare requested a review from PeachThinking as a code owner June 4, 2024 10:02
PeachThinking
PeachThinking previously approved these changes Jun 5, 2024
Copy link
Copy Markdown
Contributor

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 84157a5 into dev/4.3.0 Jun 5, 2024
@yhilmare yhilmare deleted the fix/shanlu_fix_parti_ddl branch June 5, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants